The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com). ## [1.0.0-pre.6] - 2022-03-02 ### Added - NetworkAnimator now properly synchrhonizes all animation layers as well as runtime-adjusted weighting between them (#1765) - Added first set of tests for NetworkAnimator - parameter syncing, trigger set / reset, override network animator (#1735) ### Changed ### Fixed - Fixed an issue where sometimes the first client to connect to the server could see messages from the server as coming from itself. (#1683) - Fixed an issue where clients seemed to be able to send messages to ClientId 1, but these messages would actually still go to the server (id 0) instead of that client. (#1683) - Improved clarity of error messaging when a client attempts to send a message to a destination other than the server, which isn't allowed. (#1683) - Disallowed async keyword in RPCs (#1681) - Fixed an issue where Alpha release versions of Unity (version 2022.2.0a5 and later) will not compile due to the UNet Transport no longer existing (#1678) - Fixed messages larger than 64k being written with incorrectly truncated message size in header (#1686) (credit: @kaen) - Fixed overloading RPC methods causing collisions and failing on IL2CPP targets. (#1694) - Fixed spawn flow to propagate `IsSceneObject` down to children NetworkObjects, decouple implicit relationship between object spawning & `IsSceneObject` flag (#1685) - Fixed error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate (#1720) - Fixed CheckObjectVisibility delegate not being properly invoked for connecting clients when Scene Management is enabled. (#1680) - Fixed NetworkList to properly call INetworkSerializable's NetworkSerialize() method (#1682) - Fixed NetworkVariables containing more than 1300 bytes of data (such as large NetworkLists) no longer cause an OverflowException (the limit on data size is now whatever limit the chosen transport imposes on fragmented NetworkDelivery mechanisms) (#1725) - Fixed ServerRpcParams and ClientRpcParams must be the last parameter of an RPC in order to function properly. Added a compile-time check to ensure this is the case and trigger an error if they're placed elsewhere (#1721) - Fixed FastBufferReader being created with a length of 1 if provided an input of length 0 (#1724) - Fixed The NetworkConfig's checksum hash includes the NetworkTick so that clients with a different tickrate than the server are identified and not allowed to connect (#1728) - Fixed OwnedObjects not being properly modified when using ChangeOwnership (#1731) - Improved performance in NetworkAnimator (#1735) - Removed the "always sync" network animator (aka "autosend") parameters (#1746)
134 lines
5.1 KiB
C#
134 lines
5.1 KiB
C#
using System.Collections;
|
|
using NUnit.Framework;
|
|
using UnityEngine;
|
|
using UnityEngine.TestTools;
|
|
using Unity.Netcode.TestHelpers.Runtime;
|
|
|
|
|
|
namespace Unity.Netcode.RuntimeTests
|
|
{
|
|
/// <summary>
|
|
/// Tests that check OnNetworkDespawn being invoked
|
|
/// </summary>
|
|
public class NetworkObjectOnNetworkDespawnTests
|
|
{
|
|
private NetworkManager m_ServerHost;
|
|
private NetworkManager[] m_Clients;
|
|
|
|
private GameObject m_ObjectToSpawn;
|
|
private NetworkObject m_NetworkObject;
|
|
|
|
internal class OnNetworkDespawnTestComponent : NetworkBehaviour
|
|
{
|
|
public bool OnNetworkDespawnCalled { get; internal set; }
|
|
|
|
public override void OnNetworkSpawn()
|
|
{
|
|
OnNetworkDespawnCalled = false;
|
|
base.OnNetworkSpawn();
|
|
}
|
|
|
|
public override void OnNetworkDespawn()
|
|
{
|
|
OnNetworkDespawnCalled = true;
|
|
base.OnNetworkDespawn();
|
|
}
|
|
}
|
|
|
|
[UnitySetUp]
|
|
public IEnumerator Setup()
|
|
{
|
|
Assert.IsTrue(NetcodeIntegrationTestHelpers.Create(1, out m_ServerHost, out m_Clients));
|
|
|
|
m_ObjectToSpawn = new GameObject();
|
|
m_NetworkObject = m_ObjectToSpawn.AddComponent<NetworkObject>();
|
|
m_ObjectToSpawn.AddComponent<OnNetworkDespawnTestComponent>();
|
|
|
|
// Make it a prefab
|
|
NetcodeIntegrationTestHelpers.MakeNetworkObjectTestPrefab(m_NetworkObject);
|
|
|
|
var networkPrefab = new NetworkPrefab();
|
|
networkPrefab.Prefab = m_ObjectToSpawn;
|
|
m_ServerHost.NetworkConfig.NetworkPrefabs.Add(networkPrefab);
|
|
|
|
foreach (var client in m_Clients)
|
|
{
|
|
client.NetworkConfig.NetworkPrefabs.Add(networkPrefab);
|
|
}
|
|
|
|
yield return null;
|
|
}
|
|
|
|
[UnityTearDown]
|
|
public IEnumerator Teardown()
|
|
{
|
|
// Shutdown and clean up both of our NetworkManager instances
|
|
if (m_ObjectToSpawn)
|
|
{
|
|
Object.Destroy(m_ObjectToSpawn);
|
|
m_ObjectToSpawn = null;
|
|
}
|
|
NetcodeIntegrationTestHelpers.Destroy();
|
|
yield return null;
|
|
}
|
|
|
|
public enum InstanceType
|
|
{
|
|
Server,
|
|
Host,
|
|
Client
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that a spawned NetworkObject's associated NetworkBehaviours will have
|
|
/// their OnNetworkDespawn invoked during NetworkManager shutdown.
|
|
/// </summary>
|
|
[UnityTest]
|
|
public IEnumerator TestNetworkObjectDespawnOnShutdown([Values(InstanceType.Server, InstanceType.Host, InstanceType.Client)] InstanceType despawnCheck)
|
|
{
|
|
var useHost = despawnCheck != InstanceType.Server;
|
|
var networkManager = despawnCheck == InstanceType.Host || despawnCheck == InstanceType.Server ? m_ServerHost : m_Clients[0];
|
|
|
|
// Start the instances
|
|
if (!NetcodeIntegrationTestHelpers.Start(useHost, m_ServerHost, m_Clients))
|
|
{
|
|
Debug.LogError("Failed to start instances");
|
|
Assert.Fail("Failed to start instances");
|
|
}
|
|
|
|
// [Client-Side] Wait for a connection to the server
|
|
yield return NetcodeIntegrationTestHelpers.WaitForClientsConnected(m_Clients, null, 512);
|
|
|
|
// [Host-Server-Side] Check to make sure all clients are connected
|
|
var clientCount = useHost ? m_Clients.Length + 1 : m_Clients.Length;
|
|
yield return NetcodeIntegrationTestHelpers.WaitForClientsConnectedToServer(m_ServerHost, clientCount, null, 512);
|
|
|
|
// Spawn the test object
|
|
var spawnedObject = Object.Instantiate(m_NetworkObject);
|
|
var spawnedNetworkObject = spawnedObject.GetComponent<NetworkObject>();
|
|
spawnedNetworkObject.NetworkManagerOwner = m_ServerHost;
|
|
spawnedNetworkObject.Spawn(true);
|
|
|
|
// Get the spawned object relative to which NetworkManager instance we are testing.
|
|
var relativeSpawnedObject = new NetcodeIntegrationTestHelpers.ResultWrapper<NetworkObject>();
|
|
yield return NetcodeIntegrationTestHelpers.GetNetworkObjectByRepresentation((x => x.GetComponent<OnNetworkDespawnTestComponent>() != null), networkManager, relativeSpawnedObject);
|
|
var onNetworkDespawnTestComponent = relativeSpawnedObject.Result.GetComponent<OnNetworkDespawnTestComponent>();
|
|
|
|
// Confirm it is not set before shutting down the NetworkManager
|
|
Assert.IsFalse(onNetworkDespawnTestComponent.OnNetworkDespawnCalled);
|
|
|
|
// Shutdown the NetworkManager instance we are testing.
|
|
networkManager.Shutdown();
|
|
|
|
// Since shutdown is now delayed until the post frame update
|
|
// just wait 2 frames before checking to see if OnNetworkDespawnCalled is true
|
|
var currentFrame = Time.frameCount + 2;
|
|
yield return new WaitUntil(() => Time.frameCount <= currentFrame);
|
|
|
|
// Confirm that OnNetworkDespawn is invoked after shutdown
|
|
Assert.IsTrue(onNetworkDespawnTestComponent.OnNetworkDespawnCalled);
|
|
}
|
|
}
|
|
}
|
|
|