The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com). ## [1.0.0-pre.7] - 2022-04-01 ### Added - Added editor only check prior to entering into play mode if the currently open and active scene is in the build list and if not displays a dialog box asking the user if they would like to automatically add it prior to entering into play mode. (#1828) - Added `UnityTransport` implementation and `com.unity.transport` package dependency (#1823) - Added `NetworkVariableWritePermission` to `NetworkVariableBase` and implemented `Owner` client writable netvars. (#1762) - `UnityTransport` settings can now be set programmatically. (#1845) - `FastBufferWriter` and Reader IsInitialized property. (#1859) ### Changed - Updated `UnityTransport` dependency on `com.unity.transport` to 1.0.0 (#1849) ### Removed - Removed `SnapshotSystem` (#1852) - Removed `com.unity.modules.animation`, `com.unity.modules.physics` and `com.unity.modules.physics2d` dependencies from the package (#1812) - Removed `com.unity.collections` dependency from the package (#1849) ### Fixed - Fixed in-scene placed NetworkObjects not being found/ignored after a client disconnects and then reconnects. (#1850) - Fixed issue where `UnityTransport` send queues were not flushed when calling `DisconnectLocalClient` or `DisconnectRemoteClient`. (#1847) - Fixed NetworkBehaviour dependency verification check for an existing NetworkObject not searching from root parent transform relative GameObject. (#1841) - Fixed issue where entries were not being removed from the NetworkSpawnManager.OwnershipToObjectsTable. (#1838) - Fixed ClientRpcs would always send to all connected clients by default as opposed to only sending to the NetworkObject's Observers list by default. (#1836) - Fixed clarity for NetworkSceneManager client side notification when it receives a scene hash value that does not exist in its local hash table. (#1828) - Fixed client throws a key not found exception when it times out using UNet or UTP. (#1821) - Fixed network variable updates are no longer limited to 32,768 bytes when NetworkConfig.EnsureNetworkVariableLengthSafety is enabled. The limits are now determined by what the transport can send in a message. (#1811) - Fixed in-scene NetworkObjects get destroyed if a client fails to connect and shuts down the NetworkManager. (#1809) - Fixed user never being notified in the editor that a NetworkBehaviour requires a NetworkObject to function properly. (#1808) - Fixed PlayerObjects and dynamically spawned NetworkObjects not being added to the NetworkClient's OwnedObjects (#1801) - Fixed issue where NetworkManager would continue starting even if the NetworkTransport selected failed. (#1780) - Fixed issue when spawning new player if an already existing player exists it does not remove IsPlayer from the previous player (#1779) - Fixed lack of notification that NetworkManager and NetworkObject cannot be added to the same GameObject with in-editor notifications (#1777) - Fixed parenting warning printing for false positives (#1855)
233 lines
12 KiB
C#
233 lines
12 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using Unity.Collections;
|
|
|
|
namespace Unity.Netcode
|
|
{
|
|
/// <summary>
|
|
/// This particular struct is a little weird because it doesn't actually contain the data
|
|
/// it's serializing. Instead, it contains references to the data it needs to do the
|
|
/// serialization. This is due to the generally amorphous nature of network variable
|
|
/// deltas, since they're all driven by custom virtual method overloads.
|
|
/// </summary>
|
|
internal struct NetworkVariableDeltaMessage : INetworkMessage
|
|
{
|
|
public ulong NetworkObjectId;
|
|
public ushort NetworkBehaviourIndex;
|
|
|
|
public HashSet<int> DeliveryMappedNetworkVariableIndex;
|
|
public ulong TargetClientId;
|
|
public NetworkBehaviour NetworkBehaviour;
|
|
|
|
private FastBufferReader m_ReceivedNetworkVariableData;
|
|
|
|
public void Serialize(FastBufferWriter writer)
|
|
{
|
|
if (!writer.TryBeginWrite(FastBufferWriter.GetWriteSize(NetworkObjectId) + FastBufferWriter.GetWriteSize(NetworkBehaviourIndex)))
|
|
{
|
|
throw new OverflowException($"Not enough space in the buffer to write {nameof(NetworkVariableDeltaMessage)}");
|
|
}
|
|
|
|
writer.WriteValue(NetworkObjectId);
|
|
writer.WriteValue(NetworkBehaviourIndex);
|
|
|
|
for (int i = 0; i < NetworkBehaviour.NetworkVariableFields.Count; i++)
|
|
{
|
|
if (!DeliveryMappedNetworkVariableIndex.Contains(i))
|
|
{
|
|
// This var does not belong to the currently iterating delivery group.
|
|
if (NetworkBehaviour.NetworkManager.NetworkConfig.EnsureNetworkVariableLengthSafety)
|
|
{
|
|
writer.WriteValueSafe((ushort)0);
|
|
}
|
|
else
|
|
{
|
|
writer.WriteValueSafe(false);
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
var startingSize = writer.Length;
|
|
var networkVariable = NetworkBehaviour.NetworkVariableFields[i];
|
|
var shouldWrite = networkVariable.IsDirty() &&
|
|
networkVariable.CanClientRead(TargetClientId) &&
|
|
(NetworkBehaviour.NetworkManager.IsServer || networkVariable.CanClientWrite(NetworkBehaviour.NetworkManager.LocalClientId));
|
|
|
|
if (NetworkBehaviour.NetworkManager.NetworkConfig.EnsureNetworkVariableLengthSafety)
|
|
{
|
|
if (!shouldWrite)
|
|
{
|
|
BytePacker.WriteValueBitPacked(writer, 0);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
writer.WriteValueSafe(shouldWrite);
|
|
}
|
|
|
|
if (shouldWrite)
|
|
{
|
|
if (NetworkBehaviour.NetworkManager.NetworkConfig.EnsureNetworkVariableLengthSafety)
|
|
{
|
|
var tempWriter = new FastBufferWriter(MessagingSystem.NON_FRAGMENTED_MESSAGE_MAX_SIZE, Allocator.Temp, MessagingSystem.FRAGMENTED_MESSAGE_MAX_SIZE);
|
|
NetworkBehaviour.NetworkVariableFields[i].WriteDelta(tempWriter);
|
|
BytePacker.WriteValueBitPacked(writer, tempWriter.Length);
|
|
|
|
if (!writer.TryBeginWrite(tempWriter.Length))
|
|
{
|
|
throw new OverflowException($"Not enough space in the buffer to write {nameof(NetworkVariableDeltaMessage)}");
|
|
}
|
|
|
|
tempWriter.CopyTo(writer);
|
|
}
|
|
else
|
|
{
|
|
networkVariable.WriteDelta(writer);
|
|
}
|
|
|
|
if (!NetworkBehaviour.NetworkVariableIndexesToResetSet.Contains(i))
|
|
{
|
|
NetworkBehaviour.NetworkVariableIndexesToResetSet.Add(i);
|
|
NetworkBehaviour.NetworkVariableIndexesToReset.Add(i);
|
|
}
|
|
|
|
NetworkBehaviour.NetworkManager.NetworkMetrics.TrackNetworkVariableDeltaSent(
|
|
TargetClientId,
|
|
NetworkBehaviour.NetworkObject,
|
|
networkVariable.Name,
|
|
NetworkBehaviour.__getTypeName(),
|
|
writer.Length - startingSize);
|
|
}
|
|
}
|
|
}
|
|
|
|
public bool Deserialize(FastBufferReader reader, ref NetworkContext context)
|
|
{
|
|
if (!reader.TryBeginRead(FastBufferWriter.GetWriteSize(NetworkObjectId) + FastBufferWriter.GetWriteSize(NetworkBehaviourIndex)))
|
|
{
|
|
throw new OverflowException($"Not enough data in the buffer to read {nameof(NetworkVariableDeltaMessage)}");
|
|
}
|
|
|
|
reader.ReadValue(out NetworkObjectId);
|
|
reader.ReadValue(out NetworkBehaviourIndex);
|
|
|
|
m_ReceivedNetworkVariableData = reader;
|
|
|
|
return true;
|
|
}
|
|
|
|
public void Handle(ref NetworkContext context)
|
|
{
|
|
var networkManager = (NetworkManager)context.SystemOwner;
|
|
|
|
if (networkManager.SpawnManager.SpawnedObjects.TryGetValue(NetworkObjectId, out NetworkObject networkObject))
|
|
{
|
|
var networkBehaviour = networkObject.GetNetworkBehaviourAtOrderIndex(NetworkBehaviourIndex);
|
|
|
|
if (networkBehaviour == null)
|
|
{
|
|
if (NetworkLog.CurrentLogLevel <= LogLevel.Normal)
|
|
{
|
|
NetworkLog.LogWarning($"Network variable delta message received for a non-existent behaviour. {nameof(NetworkObjectId)}: {NetworkObjectId}, {nameof(NetworkBehaviourIndex)}: {NetworkBehaviourIndex}");
|
|
}
|
|
}
|
|
else
|
|
{
|
|
for (int i = 0; i < networkBehaviour.NetworkVariableFields.Count; i++)
|
|
{
|
|
int varSize = 0;
|
|
if (networkManager.NetworkConfig.EnsureNetworkVariableLengthSafety)
|
|
{
|
|
ByteUnpacker.ReadValueBitPacked(m_ReceivedNetworkVariableData, out varSize);
|
|
|
|
if (varSize == 0)
|
|
{
|
|
continue;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
m_ReceivedNetworkVariableData.ReadValueSafe(out bool deltaExists);
|
|
if (!deltaExists)
|
|
{
|
|
continue;
|
|
}
|
|
}
|
|
|
|
var networkVariable = networkBehaviour.NetworkVariableFields[i];
|
|
|
|
if (networkManager.IsServer && !networkVariable.CanClientWrite(context.SenderId))
|
|
{
|
|
// we are choosing not to fire an exception here, because otherwise a malicious client could use this to crash the server
|
|
if (networkManager.NetworkConfig.EnsureNetworkVariableLengthSafety)
|
|
{
|
|
if (NetworkLog.CurrentLogLevel <= LogLevel.Developer)
|
|
{
|
|
NetworkLog.LogWarning($"Client wrote to {typeof(NetworkVariable<>).Name} without permission. => {nameof(NetworkObjectId)}: {NetworkObjectId} - {nameof(NetworkObject.GetNetworkBehaviourOrderIndex)}(): {networkObject.GetNetworkBehaviourOrderIndex(networkBehaviour)} - VariableIndex: {i}");
|
|
NetworkLog.LogError($"[{networkVariable.GetType().Name}]");
|
|
}
|
|
|
|
m_ReceivedNetworkVariableData.Seek(m_ReceivedNetworkVariableData.Position + varSize);
|
|
continue;
|
|
}
|
|
|
|
//This client wrote somewhere they are not allowed. This is critical
|
|
//We can't just skip this field. Because we don't actually know how to dummy read
|
|
//That is, we don't know how many bytes to skip. Because the interface doesn't have a
|
|
//Read that gives us the value. Only a Read that applies the value straight away
|
|
//A dummy read COULD be added to the interface for this situation, but it's just being too nice.
|
|
//This is after all a developer fault. A critical error should be fine.
|
|
// - TwoTen
|
|
if (NetworkLog.CurrentLogLevel <= LogLevel.Developer)
|
|
{
|
|
NetworkLog.LogError($"Client wrote to {typeof(NetworkVariable<>).Name} without permission. No more variables can be read. This is critical. => {nameof(NetworkObjectId)}: {NetworkObjectId} - {nameof(NetworkObject.GetNetworkBehaviourOrderIndex)}(): {networkObject.GetNetworkBehaviourOrderIndex(networkBehaviour)} - VariableIndex: {i}");
|
|
NetworkLog.LogError($"[{networkVariable.GetType().Name}]");
|
|
}
|
|
|
|
return;
|
|
}
|
|
int readStartPos = m_ReceivedNetworkVariableData.Position;
|
|
|
|
networkVariable.ReadDelta(m_ReceivedNetworkVariableData, networkManager.IsServer);
|
|
|
|
networkManager.NetworkMetrics.TrackNetworkVariableDeltaReceived(
|
|
context.SenderId,
|
|
networkObject,
|
|
networkVariable.Name,
|
|
networkBehaviour.__getTypeName(),
|
|
context.MessageSize);
|
|
|
|
|
|
if (networkManager.NetworkConfig.EnsureNetworkVariableLengthSafety)
|
|
{
|
|
if (m_ReceivedNetworkVariableData.Position > (readStartPos + varSize))
|
|
{
|
|
if (NetworkLog.CurrentLogLevel <= LogLevel.Normal)
|
|
{
|
|
NetworkLog.LogWarning($"Var delta read too far. {m_ReceivedNetworkVariableData.Position - (readStartPos + varSize)} bytes. => {nameof(NetworkObjectId)}: {NetworkObjectId} - {nameof(NetworkObject.GetNetworkBehaviourOrderIndex)}(): {networkObject.GetNetworkBehaviourOrderIndex(networkBehaviour)} - VariableIndex: {i}");
|
|
}
|
|
|
|
m_ReceivedNetworkVariableData.Seek(readStartPos + varSize);
|
|
}
|
|
else if (m_ReceivedNetworkVariableData.Position < (readStartPos + varSize))
|
|
{
|
|
if (NetworkLog.CurrentLogLevel <= LogLevel.Normal)
|
|
{
|
|
NetworkLog.LogWarning($"Var delta read too little. {readStartPos + varSize - m_ReceivedNetworkVariableData.Position} bytes. => {nameof(NetworkObjectId)}: {NetworkObjectId} - {nameof(NetworkObject.GetNetworkBehaviourOrderIndex)}(): {networkObject.GetNetworkBehaviourOrderIndex(networkBehaviour)} - VariableIndex: {i}");
|
|
}
|
|
|
|
m_ReceivedNetworkVariableData.Seek(readStartPos + varSize);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
else
|
|
{
|
|
networkManager.SpawnManager.TriggerOnSpawn(NetworkObjectId, m_ReceivedNetworkVariableData, ref context);
|
|
}
|
|
}
|
|
}
|
|
}
|