The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com). ## [2.0.0-exp.4] - 2024-05-31 ### Added - Added `NetworkRigidbodyBase.AttachToFixedJoint` and `NetworkRigidbodyBase.DetachFromFixedJoint` to replace parenting for rigid bodies that have `NetworkRigidbodyBase.UseRigidBodyForMotion` enabled. (#2933) - Added `NetworkBehaviour.OnNetworkPreSpawn` and `NetworkBehaviour.OnNetworkPostSpawn` methods that provide the ability to handle pre and post spawning actions during the `NetworkObject` spawn sequence. (#2912) - Added a client-side only `NetworkBehaviour.OnNetworkSessionSynchronized` convenience method that is invoked on all `NetworkBehaviour`s after a newly joined client has finished synchronizing with the network session in progress. (#2912) - Added `NetworkBehaviour.OnInSceneObjectsSpawned` convenience method that is invoked when all in-scene `NetworkObject`s have been spawned after a scene has been loaded or upon a host or server starting. (#2912) ### Fixed - Fixed issue where non-authoritative rigid bodies with `NetworkRigidbodyBase.UseRigidBodyForMotion` enabled would constantly log errors about the renderTime being before `StartTimeConsumed`. (#2933) - Fixed issue where in-scene placed NetworkObjects could be destroyed if a client disconnects early and/or before approval. (#2924) - Fixed issue where a `NetworkObject` component's associated `NetworkBehaviour` components would not be detected if scene loading is disabled in the editor and the currently loaded scene has in-scene placed `NetworkObject`s. (#2912) - Fixed issue where an in-scene placed `NetworkObject` with `NetworkTransform` that is also parented under a `GameObject` would not properly synchronize when the parent `GameObject` had a world space position other than 0,0,0. (#2898) ### Changed - Change all the access modifiers of test class from Public to Internal (#2930) - Changed messages are now sorted by enum values as opposed to ordinally sorting the messages by their type name. (#2929) - Changed `NetworkClient.SessionModeTypes` to `NetworkClient.NetworkTopologyTypes`. (#2875) - Changed `NetworkClient.SessionModeType` to `NetworkClient.NetworkTopologyType`. (#2875) - Changed `NetworkConfig.SessionMode` to `NeworkConfig.NetworkTopology`. (#2875)
204 lines
7.7 KiB
C#
204 lines
7.7 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Text.RegularExpressions;
|
|
using NUnit.Framework;
|
|
using NUnit.Framework.Internal;
|
|
using Unity.Collections;
|
|
using Unity.Collections.LowLevel.Unsafe;
|
|
using UnityEngine;
|
|
using UnityEngine.TestTools;
|
|
|
|
namespace Unity.Netcode.EditorTests
|
|
{
|
|
internal class MessageCorruptionTests
|
|
{
|
|
|
|
private struct TestMessage : INetworkMessage, INetworkSerializeByMemcpy
|
|
{
|
|
public ForceNetworkSerializeByMemcpy<Guid> Value;
|
|
public static bool Handled;
|
|
public static bool Deserialized;
|
|
|
|
public void Serialize(FastBufferWriter writer, int targetVersion)
|
|
{
|
|
writer.WriteValueSafe(Value);
|
|
}
|
|
|
|
public bool Deserialize(FastBufferReader reader, ref NetworkContext context, int receivedMessageVersion)
|
|
{
|
|
Deserialized = true;
|
|
reader.ReadValueSafe(out Value);
|
|
return true;
|
|
}
|
|
|
|
public void Handle(ref NetworkContext context)
|
|
{
|
|
Handled = true;
|
|
}
|
|
|
|
public int Version => 0;
|
|
}
|
|
|
|
private class TestMessageProvider : INetworkMessageProvider
|
|
{
|
|
public List<NetworkMessageManager.MessageWithHandler> GetMessages()
|
|
{
|
|
return new List<NetworkMessageManager.MessageWithHandler>
|
|
{
|
|
new NetworkMessageManager.MessageWithHandler
|
|
{
|
|
MessageType = typeof(TestMessage),
|
|
Handler = NetworkMessageManager.ReceiveMessage<TestMessage>,
|
|
GetVersion = NetworkMessageManager.CreateMessageAndGetVersion<TestMessage>
|
|
}
|
|
};
|
|
}
|
|
}
|
|
|
|
public enum TypeOfCorruption
|
|
{
|
|
OffsetPlus,
|
|
OffsetMinus,
|
|
CorruptBytes,
|
|
Truncated,
|
|
AdditionalGarbageData,
|
|
}
|
|
|
|
private class TestMessageSender : INetworkMessageSender
|
|
{
|
|
|
|
public TypeOfCorruption Corruption;
|
|
public List<byte[]> MessageQueue = new List<byte[]>();
|
|
|
|
public unsafe void Send(ulong clientId, NetworkDelivery delivery, FastBufferWriter batchData)
|
|
{
|
|
switch (Corruption)
|
|
{
|
|
case TypeOfCorruption.OffsetPlus:
|
|
{
|
|
using var subWriter = new FastBufferWriter(batchData.Length + 1, Allocator.Temp);
|
|
subWriter.WriteByteSafe(0);
|
|
subWriter.WriteBytesSafe(batchData.GetUnsafePtr(), batchData.Length);
|
|
MessageQueue.Add(subWriter.ToArray());
|
|
break;
|
|
}
|
|
case TypeOfCorruption.OffsetMinus:
|
|
{
|
|
using var subWriter = new FastBufferWriter(batchData.Length - 1, Allocator.Temp);
|
|
subWriter.WriteBytesSafe(batchData.GetUnsafePtr() + 1, batchData.Length - 1);
|
|
MessageQueue.Add(subWriter.ToArray());
|
|
break;
|
|
}
|
|
case TypeOfCorruption.CorruptBytes:
|
|
batchData.Seek(batchData.Length - 2);
|
|
var currentByte = batchData.GetUnsafePtr()[0];
|
|
batchData.WriteByteSafe((byte)(currentByte == 0 ? 1 : 0));
|
|
MessageQueue.Add(batchData.ToArray());
|
|
break;
|
|
case TypeOfCorruption.Truncated:
|
|
batchData.Truncate(batchData.Length - 1);
|
|
MessageQueue.Add(batchData.ToArray());
|
|
break;
|
|
case TypeOfCorruption.AdditionalGarbageData:
|
|
batchData.Seek(batchData.Length);
|
|
batchData.WriteByteSafe(0);
|
|
MessageQueue.Add(batchData.ToArray());
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
private NetworkMessageManager m_MessageManager;
|
|
private TestMessageSender m_MessageSender;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
TestMessage.Handled = false;
|
|
TestMessage.Deserialized = false;
|
|
m_MessageSender = new TestMessageSender();
|
|
|
|
m_MessageManager = new NetworkMessageManager(m_MessageSender, this, new TestMessageProvider());
|
|
|
|
m_MessageManager.ClientConnected(0);
|
|
m_MessageManager.SetVersion(0, XXHash.Hash32(typeof(TestMessage).FullName), 0);
|
|
}
|
|
|
|
[TearDown]
|
|
public void TearDown()
|
|
{
|
|
m_MessageManager.Dispose();
|
|
}
|
|
|
|
private TestMessage GetMessage()
|
|
{
|
|
return new TestMessage
|
|
{
|
|
Value = Guid.NewGuid()
|
|
};
|
|
}
|
|
|
|
[Test]
|
|
public unsafe void WhenPacketsAreCorrupted_TheyDontGetProcessed([Values] TypeOfCorruption typeOfCorruption)
|
|
{
|
|
m_MessageSender.Corruption = typeOfCorruption;
|
|
|
|
switch (typeOfCorruption)
|
|
{
|
|
case TypeOfCorruption.OffsetMinus:
|
|
case TypeOfCorruption.OffsetPlus:
|
|
LogAssert.Expect(LogType.Error, new Regex("Received a packet with an invalid Magic Value\\."));
|
|
break;
|
|
case TypeOfCorruption.Truncated:
|
|
case TypeOfCorruption.AdditionalGarbageData:
|
|
LogAssert.Expect(LogType.Error, new Regex("Received a packet with an invalid Batch Size Value\\."));
|
|
break;
|
|
case TypeOfCorruption.CorruptBytes:
|
|
LogAssert.Expect(LogType.Error, new Regex("Received a packet with an invalid Hash Value\\."));
|
|
break;
|
|
}
|
|
|
|
// Dummy batch header
|
|
var batchHeader = new NetworkBatchHeader
|
|
{
|
|
BatchCount = 1
|
|
};
|
|
var messageHeader = new NetworkMessageHeader
|
|
{
|
|
MessageSize = (ushort)UnsafeUtility.SizeOf<TestMessage>(),
|
|
MessageType = m_MessageManager.GetMessageType(typeof(TestMessage)),
|
|
};
|
|
var message = GetMessage();
|
|
|
|
var writer = new FastBufferWriter(1300, Allocator.Temp);
|
|
using (writer)
|
|
{
|
|
writer.TryBeginWrite(FastBufferWriter.GetWriteSize(batchHeader) +
|
|
FastBufferWriter.GetWriteSize(messageHeader) +
|
|
FastBufferWriter.GetWriteSize(message));
|
|
writer.WriteValue(batchHeader);
|
|
writer.WriteValue(messageHeader);
|
|
writer.WriteValue(message);
|
|
|
|
// Fill out the rest of the batch header
|
|
writer.Seek(0);
|
|
batchHeader = new NetworkBatchHeader
|
|
{
|
|
Magic = NetworkBatchHeader.MagicValue,
|
|
BatchSize = writer.Length,
|
|
BatchHash = XXHash.Hash64(writer.GetUnsafePtr() + sizeof(NetworkBatchHeader), writer.Length - sizeof(NetworkBatchHeader)),
|
|
BatchCount = 1
|
|
};
|
|
writer.WriteValue(batchHeader);
|
|
m_MessageSender.Send(0, NetworkDelivery.Reliable, writer);
|
|
|
|
var receivedMessage = m_MessageSender.MessageQueue[0];
|
|
m_MessageSender.MessageQueue.Clear();
|
|
m_MessageManager.HandleIncomingData(0, new ArraySegment<byte>(receivedMessage), 0);
|
|
Assert.IsFalse(TestMessage.Deserialized);
|
|
Assert.IsFalse(TestMessage.Handled);
|
|
}
|
|
}
|
|
}
|
|
}
|