The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com). ## [2.0.0] - 2024-09-12 ### Added - Added tooltips for all of the `NetworkObject` component's properties. (#3052) - Added message size validation to named and unnamed message sending functions for better error messages. (#3049) - Added "Check for NetworkObject Component" property to the Multiplayer->Netcode for GameObjects project settings. When disabled, this will bypass the in-editor `NetworkObject` check on `NetworkBehaviour` components. (#3031) - Added `NetworkTransform.SwitchTransformSpaceWhenParented` property that, when enabled, will handle the world to local, local to world, and local to local transform space transitions when interpolation is enabled. (#3013) - Added `NetworkTransform.TickSyncChildren` that, when enabled, will tick synchronize nested and/or child `NetworkTransform` components to eliminate any potential visual jittering that could occur if the `NetworkTransform` instances get into a state where their state updates are landing on different network ticks. (#3013) - Added `NetworkObject.AllowOwnerToParent` property to provide the ability to allow clients to parent owned objects when running in a client-server network topology. (#3013) - Added `NetworkObject.SyncOwnerTransformWhenParented` property to provide a way to disable applying the server's transform information in the parenting message on the client owner instance which can be useful for owner authoritative motion models. (#3013) - Added `NetcodeEditorBase` editor helper class to provide easier modification and extension of the SDK's components. (#3013) ### Fixed - Fixed issue where `NetworkAnimator` would send updates to non-observer clients. (#3057) - Fixed issue where an exception could occur when receiving a universal RPC for a `NetworkObject` that has been despawned. (#3052) - Fixed issue where a NetworkObject hidden from a client that is then promoted to be session owner was not being synchronized with newly joining clients.(#3051) - Fixed issue where clients could have a wrong time delta on `NetworkVariableBase` which could prevent from sending delta state updates. (#3045) - Fixed issue where setting a prefab hash value during connection approval but not having a player prefab assigned could cause an exception when spawning a player. (#3042) - Fixed issue where the `NetworkSpawnManager.HandleNetworkObjectShow` could throw an exception if one of the `NetworkObject` components to show was destroyed during the same frame. (#3030) - Fixed issue where the `NetworkManagerHelper` was continuing to check for hierarchy changes when in play mode. (#3026) - Fixed issue with newly/late joined clients and `NetworkTransform` synchronization of parented `NetworkObject` instances. (#3013) - Fixed issue with smooth transitions between transform spaces when interpolation is enabled (requires `NetworkTransform.SwitchTransformSpaceWhenParented` to be enabled). (#3013) ### Changed - Changed `NetworkTransformEditor` now uses `NetworkTransform` as the base type class to assure it doesn't display a foldout group when using the base `NetworkTransform` component class. (#3052) - Changed `NetworkAnimator.Awake` is now a protected virtual method. (#3052) - Changed when invoking `NetworkManager.ConnectionManager.DisconnectClient` during a distributed authority session a more appropriate message is logged. (#3052) - Changed `NetworkTransformEditor` so it now derives from `NetcodeEditorBase`. (#3013) - Changed `NetworkRigidbodyBaseEditor` so it now derives from `NetcodeEditorBase`. (#3013) - Changed `NetworkManagerEditor` so it now derives from `NetcodeEditorBase`. (#3013)
238 lines
11 KiB
C#
238 lines
11 KiB
C#
using System;
|
|
using System.Collections;
|
|
using System.Collections.Generic;
|
|
using NUnit.Framework;
|
|
using Unity.Collections;
|
|
using Unity.Netcode.TestHelpers.Runtime;
|
|
using UnityEngine.TestTools;
|
|
|
|
namespace Unity.Netcode.RuntimeTests
|
|
{
|
|
internal class UnnamedMessageTests : NetcodeIntegrationTest
|
|
{
|
|
protected override int NumberOfClients => 2;
|
|
|
|
private NetworkManager FirstClient => m_ClientNetworkManagers[0];
|
|
private NetworkManager SecondClient => m_ClientNetworkManagers[1];
|
|
|
|
[UnityTest]
|
|
public IEnumerator UnnamedMessageIsReceivedOnClientWithContent()
|
|
{
|
|
ulong receivedMessageSender = 0;
|
|
var receivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
|
|
FirstClient.CustomMessagingManager.OnUnnamedMessage +=
|
|
(ulong sender, FastBufferReader reader) =>
|
|
{
|
|
receivedMessageSender = sender;
|
|
|
|
reader.ReadValueSafe(out receivedMessageContent);
|
|
};
|
|
|
|
var messageContent = new ForceNetworkSerializeByMemcpy<Guid>(Guid.NewGuid());
|
|
var writer = new FastBufferWriter(1300, Allocator.Temp);
|
|
using (writer)
|
|
{
|
|
writer.WriteValueSafe(messageContent);
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessage(
|
|
FirstClient.LocalClientId,
|
|
writer);
|
|
}
|
|
|
|
yield return WaitForMessageReceived<UnnamedMessage>(new List<NetworkManager> { FirstClient });
|
|
|
|
Assert.AreEqual(messageContent.Value, receivedMessageContent.Value);
|
|
Assert.AreEqual(m_ServerNetworkManager.LocalClientId, receivedMessageSender);
|
|
}
|
|
|
|
[Test]
|
|
public void UnnamedMessageIsReceivedOnHostWithContent()
|
|
{
|
|
ulong receivedMessageSender = 0;
|
|
var receivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
|
|
m_ServerNetworkManager.CustomMessagingManager.OnUnnamedMessage +=
|
|
(ulong sender, FastBufferReader reader) =>
|
|
{
|
|
receivedMessageSender = sender;
|
|
|
|
reader.ReadValueSafe(out receivedMessageContent);
|
|
};
|
|
|
|
var messageContent = new ForceNetworkSerializeByMemcpy<Guid>(Guid.NewGuid());
|
|
var writer = new FastBufferWriter(1300, Allocator.Temp);
|
|
using (writer)
|
|
{
|
|
writer.WriteValueSafe(messageContent);
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessage(
|
|
m_ServerNetworkManager.LocalClientId,
|
|
writer);
|
|
}
|
|
|
|
Assert.AreEqual(messageContent.Value, receivedMessageContent.Value);
|
|
Assert.AreEqual(m_ServerNetworkManager.LocalClientId, receivedMessageSender);
|
|
}
|
|
|
|
[UnityTest]
|
|
public IEnumerator UnnamedMessageIsReceivedOnMultipleClientsWithContent()
|
|
{
|
|
ulong firstReceivedMessageSender = 0;
|
|
var firstReceivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
|
|
FirstClient.CustomMessagingManager.OnUnnamedMessage +=
|
|
(ulong sender, FastBufferReader reader) =>
|
|
{
|
|
firstReceivedMessageSender = sender;
|
|
|
|
reader.ReadValueSafe(out firstReceivedMessageContent);
|
|
};
|
|
|
|
ulong secondReceivedMessageSender = 0;
|
|
var secondReceivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
|
|
SecondClient.CustomMessagingManager.OnUnnamedMessage +=
|
|
(ulong sender, FastBufferReader reader) =>
|
|
{
|
|
secondReceivedMessageSender = sender;
|
|
|
|
reader.ReadValueSafe(out secondReceivedMessageContent);
|
|
};
|
|
|
|
ulong thirdReceivedMessageSender = 0;
|
|
var thirdReceivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
|
|
m_ServerNetworkManager.CustomMessagingManager.OnUnnamedMessage +=
|
|
(ulong sender, FastBufferReader reader) =>
|
|
{
|
|
thirdReceivedMessageSender = sender;
|
|
|
|
reader.ReadValueSafe(out thirdReceivedMessageContent);
|
|
};
|
|
|
|
var messageContent = new ForceNetworkSerializeByMemcpy<Guid>(Guid.NewGuid());
|
|
var writer = new FastBufferWriter(1300, Allocator.Temp);
|
|
using (writer)
|
|
{
|
|
writer.WriteValueSafe(messageContent);
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessage(
|
|
new List<ulong> { m_ServerNetworkManager.LocalClientId, FirstClient.LocalClientId, SecondClient.LocalClientId },
|
|
writer);
|
|
}
|
|
|
|
yield return WaitForMessageReceived<UnnamedMessage>(new List<NetworkManager> { FirstClient, SecondClient });
|
|
|
|
Assert.AreEqual(messageContent.Value, firstReceivedMessageContent.Value);
|
|
Assert.AreEqual(m_ServerNetworkManager.LocalClientId, firstReceivedMessageSender);
|
|
|
|
Assert.AreEqual(messageContent.Value, secondReceivedMessageContent.Value);
|
|
Assert.AreEqual(m_ServerNetworkManager.LocalClientId, secondReceivedMessageSender);
|
|
|
|
Assert.AreEqual(messageContent.Value, thirdReceivedMessageContent.Value);
|
|
Assert.AreEqual(m_ServerNetworkManager.LocalClientId, thirdReceivedMessageSender);
|
|
}
|
|
|
|
[UnityTest]
|
|
public IEnumerator WhenSendingUnnamedMessageToAll_AllClientsReceiveIt()
|
|
{
|
|
ulong firstReceivedMessageSender = 0;
|
|
var firstReceivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
|
|
FirstClient.CustomMessagingManager.OnUnnamedMessage +=
|
|
(ulong sender, FastBufferReader reader) =>
|
|
{
|
|
firstReceivedMessageSender = sender;
|
|
|
|
reader.ReadValueSafe(out firstReceivedMessageContent);
|
|
};
|
|
|
|
ulong secondReceivedMessageSender = 0;
|
|
var secondReceivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
|
|
SecondClient.CustomMessagingManager.OnUnnamedMessage +=
|
|
(ulong sender, FastBufferReader reader) =>
|
|
{
|
|
secondReceivedMessageSender = sender;
|
|
|
|
reader.ReadValueSafe(out secondReceivedMessageContent);
|
|
};
|
|
|
|
ulong thirdReceivedMessageSender = 0;
|
|
var thirdReceivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
|
|
m_ServerNetworkManager.CustomMessagingManager.OnUnnamedMessage +=
|
|
(ulong sender, FastBufferReader reader) =>
|
|
{
|
|
thirdReceivedMessageSender = sender;
|
|
|
|
reader.ReadValueSafe(out thirdReceivedMessageContent);
|
|
};
|
|
|
|
var messageContent = new ForceNetworkSerializeByMemcpy<Guid>(Guid.NewGuid());
|
|
var writer = new FastBufferWriter(1300, Allocator.Temp);
|
|
using (writer)
|
|
{
|
|
writer.WriteValueSafe(messageContent);
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessageToAll(writer);
|
|
}
|
|
|
|
yield return WaitForMessageReceived<UnnamedMessage>(new List<NetworkManager> { FirstClient, SecondClient });
|
|
|
|
Assert.AreEqual(messageContent.Value, firstReceivedMessageContent.Value);
|
|
Assert.AreEqual(m_ServerNetworkManager.LocalClientId, firstReceivedMessageSender);
|
|
|
|
Assert.AreEqual(messageContent.Value, secondReceivedMessageContent.Value);
|
|
Assert.AreEqual(m_ServerNetworkManager.LocalClientId, secondReceivedMessageSender);
|
|
|
|
Assert.AreEqual(messageContent.Value, thirdReceivedMessageContent.Value);
|
|
Assert.AreEqual(m_ServerNetworkManager.LocalClientId, thirdReceivedMessageSender);
|
|
}
|
|
|
|
[Test]
|
|
public void WhenSendingNamedMessageToNullClientList_ArgumentNullExceptionIsThrown()
|
|
{
|
|
var messageContent = new ForceNetworkSerializeByMemcpy<Guid>(Guid.NewGuid());
|
|
var writer = new FastBufferWriter(1300, Allocator.Temp);
|
|
using (writer)
|
|
{
|
|
writer.WriteValueSafe(messageContent);
|
|
Assert.Throws<ArgumentNullException>(
|
|
() =>
|
|
{
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessage(null, writer);
|
|
});
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public unsafe void ErrorMessageIsPrintedWhenAttemptingToSendUnnamedMessageWithTooBigBuffer()
|
|
{
|
|
// First try a valid send with the maximum allowed size (this is atm 1272)
|
|
var msgSize = m_ServerNetworkManager.MessageManager.NonFragmentedMessageMaxSize - FastBufferWriter.GetWriteSize<NetworkMessageHeader>() - sizeof(NetworkBatchHeader);
|
|
var bufferSize = m_ServerNetworkManager.MessageManager.NonFragmentedMessageMaxSize;
|
|
var messageContent = new byte[msgSize];
|
|
var writer = new FastBufferWriter(bufferSize, Allocator.Temp, bufferSize * 2);
|
|
using (writer)
|
|
{
|
|
writer.TryBeginWrite(msgSize);
|
|
writer.WriteBytes(messageContent, msgSize, 0);
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessage(new List<ulong> { FirstClient.LocalClientId }, writer);
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessage(FirstClient.LocalClientId, writer);
|
|
}
|
|
|
|
msgSize++;
|
|
messageContent = new byte[msgSize];
|
|
writer = new FastBufferWriter(bufferSize, Allocator.Temp, bufferSize * 2);
|
|
using (writer)
|
|
{
|
|
writer.TryBeginWrite(msgSize);
|
|
writer.WriteBytes(messageContent, msgSize, 0);
|
|
var message = Assert.Throws<OverflowException>(
|
|
() =>
|
|
{
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessage(new List<ulong> { FirstClient.LocalClientId }, writer);
|
|
}).Message;
|
|
Assert.IsTrue(message.Contains($"Given message size ({msgSize} bytes) is greater than the maximum"), $"Unexpected exception: {message}");
|
|
|
|
message = Assert.Throws<OverflowException>(
|
|
() =>
|
|
{
|
|
m_ServerNetworkManager.CustomMessagingManager.SendUnnamedMessage(FirstClient.LocalClientId, writer);
|
|
}).Message;
|
|
Assert.IsTrue(message.Contains($"Given message size ({msgSize} bytes) is greater than the maximum"), $"Unexpected exception: {message}");
|
|
}
|
|
}
|
|
}
|
|
}
|