com.unity.netcode.gameobjects@1.0.0-pre.6
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com). ## [1.0.0-pre.6] - 2022-03-02 ### Added - NetworkAnimator now properly synchrhonizes all animation layers as well as runtime-adjusted weighting between them (#1765) - Added first set of tests for NetworkAnimator - parameter syncing, trigger set / reset, override network animator (#1735) ### Changed ### Fixed - Fixed an issue where sometimes the first client to connect to the server could see messages from the server as coming from itself. (#1683) - Fixed an issue where clients seemed to be able to send messages to ClientId 1, but these messages would actually still go to the server (id 0) instead of that client. (#1683) - Improved clarity of error messaging when a client attempts to send a message to a destination other than the server, which isn't allowed. (#1683) - Disallowed async keyword in RPCs (#1681) - Fixed an issue where Alpha release versions of Unity (version 2022.2.0a5 and later) will not compile due to the UNet Transport no longer existing (#1678) - Fixed messages larger than 64k being written with incorrectly truncated message size in header (#1686) (credit: @kaen) - Fixed overloading RPC methods causing collisions and failing on IL2CPP targets. (#1694) - Fixed spawn flow to propagate `IsSceneObject` down to children NetworkObjects, decouple implicit relationship between object spawning & `IsSceneObject` flag (#1685) - Fixed error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate (#1720) - Fixed CheckObjectVisibility delegate not being properly invoked for connecting clients when Scene Management is enabled. (#1680) - Fixed NetworkList to properly call INetworkSerializable's NetworkSerialize() method (#1682) - Fixed NetworkVariables containing more than 1300 bytes of data (such as large NetworkLists) no longer cause an OverflowException (the limit on data size is now whatever limit the chosen transport imposes on fragmented NetworkDelivery mechanisms) (#1725) - Fixed ServerRpcParams and ClientRpcParams must be the last parameter of an RPC in order to function properly. Added a compile-time check to ensure this is the case and trigger an error if they're placed elsewhere (#1721) - Fixed FastBufferReader being created with a length of 1 if provided an input of length 0 (#1724) - Fixed The NetworkConfig's checksum hash includes the NetworkTick so that clients with a different tickrate than the server are identified and not allowed to connect (#1728) - Fixed OwnedObjects not being properly modified when using ChangeOwnership (#1731) - Improved performance in NetworkAnimator (#1735) - Removed the "always sync" network animator (aka "autosend") parameters (#1746)
This commit is contained in:
Unity Technologies
@@ -3,22 +3,21 @@ using System.Collections.Generic;
|
||||
using NUnit.Framework;
|
||||
using UnityEngine;
|
||||
using UnityEngine.TestTools;
|
||||
using Unity.Netcode.TestHelpers.Runtime;
|
||||
|
||||
namespace Unity.Netcode.RuntimeTests
|
||||
{
|
||||
public class NetworkObjectOnSpawnTests : BaseMultiInstanceTest
|
||||
public class NetworkObjectOnSpawnTests : NetcodeIntegrationTest
|
||||
{
|
||||
private GameObject m_TestNetworkObjectPrefab;
|
||||
private GameObject m_TestNetworkObjectInstance;
|
||||
|
||||
protected override int NbClients => 2;
|
||||
|
||||
protected override int NumberOfClients => 2;
|
||||
|
||||
/// <summary>
|
||||
/// Tests that instantiating a <see cref="NetworkObject"/> and destroying without spawning it
|
||||
/// does not run <see cref="NetworkBehaviour.OnNetworkSpawn"/> or <see cref="NetworkBehaviour.OnNetworkSpawn"/>.
|
||||
/// </summary>
|
||||
/// <returns></returns>
|
||||
[UnityTest]
|
||||
public IEnumerator InstantiateDestroySpawnNotCalled()
|
||||
{
|
||||
@@ -29,6 +28,8 @@ namespace Unity.Netcode.RuntimeTests
|
||||
// instantiate
|
||||
m_TestNetworkObjectInstance = Object.Instantiate(m_TestNetworkObjectPrefab);
|
||||
yield return null;
|
||||
Object.Destroy(m_TestNetworkObjectInstance);
|
||||
|
||||
}
|
||||
|
||||
private class FailWhenSpawned : NetworkBehaviour
|
||||
@@ -44,20 +45,13 @@ namespace Unity.Netcode.RuntimeTests
|
||||
}
|
||||
}
|
||||
|
||||
[UnitySetUp]
|
||||
public override IEnumerator Setup()
|
||||
protected override void OnCreatePlayerPrefab()
|
||||
{
|
||||
yield return StartSomeClientsAndServerWithPlayers(true, NbClients, playerPrefab =>
|
||||
{
|
||||
// add test component
|
||||
playerPrefab.AddComponent<TrackOnSpawnFunctions>();
|
||||
});
|
||||
m_PlayerPrefab.AddComponent<TrackOnSpawnFunctions>();
|
||||
}
|
||||
|
||||
[UnityTearDown]
|
||||
public override IEnumerator Teardown()
|
||||
protected override IEnumerator OnTearDown()
|
||||
{
|
||||
|
||||
if (m_TestNetworkObjectPrefab != null)
|
||||
{
|
||||
Object.Destroy(m_TestNetworkObjectPrefab);
|
||||
@@ -67,10 +61,11 @@ namespace Unity.Netcode.RuntimeTests
|
||||
{
|
||||
Object.Destroy(m_TestNetworkObjectInstance);
|
||||
}
|
||||
yield return base.Teardown();
|
||||
|
||||
yield return base.OnTearDown();
|
||||
}
|
||||
|
||||
private List<TrackOnSpawnFunctions> m_ClientTrackOnSpawnInstances = new List<TrackOnSpawnFunctions>();
|
||||
|
||||
/// <summary>
|
||||
/// Test that callbacks are run for playerobject spawn, despawn, regular spawn, destroy on server.
|
||||
/// </summary>
|
||||
@@ -79,19 +74,13 @@ namespace Unity.Netcode.RuntimeTests
|
||||
public IEnumerator TestOnNetworkSpawnCallbacks()
|
||||
{
|
||||
// [Host-Side] Get the Host owned instance
|
||||
var serverClientPlayerResult = new MultiInstanceHelpers.CoroutineResultWrapper<NetworkObject>();
|
||||
yield return MultiInstanceHelpers.Run(MultiInstanceHelpers.GetNetworkObjectByRepresentation((x => x.IsPlayerObject && x.OwnerClientId == m_ClientNetworkManagers[0].LocalClientId), m_ServerNetworkManager, serverClientPlayerResult));
|
||||
var serverInstance = m_PlayerNetworkObjects[m_ServerNetworkManager.LocalClientId][m_ServerNetworkManager.LocalClientId].GetComponent<TrackOnSpawnFunctions>();
|
||||
|
||||
var serverInstance = serverClientPlayerResult.Result.GetComponent<TrackOnSpawnFunctions>();
|
||||
|
||||
var clientInstances = new List<TrackOnSpawnFunctions>();
|
||||
foreach (var client in m_ClientNetworkManagers)
|
||||
{
|
||||
var clientClientPlayerResult = new MultiInstanceHelpers.CoroutineResultWrapper<NetworkObject>();
|
||||
yield return MultiInstanceHelpers.Run(MultiInstanceHelpers.GetNetworkObjectByRepresentation((x => x.IsPlayerObject && x.OwnerClientId == m_ClientNetworkManagers[0].LocalClientId), client, clientClientPlayerResult));
|
||||
var clientRpcTests = clientClientPlayerResult.Result.GetComponent<TrackOnSpawnFunctions>();
|
||||
var clientRpcTests = m_PlayerNetworkObjects[client.LocalClientId][m_ServerNetworkManager.LocalClientId].gameObject.GetComponent<TrackOnSpawnFunctions>();
|
||||
Assert.IsNotNull(clientRpcTests);
|
||||
clientInstances.Add(clientRpcTests);
|
||||
m_ClientTrackOnSpawnInstances.Add(clientRpcTests);
|
||||
}
|
||||
|
||||
// -------------- step 1 check player spawn despawn
|
||||
@@ -99,69 +88,84 @@ namespace Unity.Netcode.RuntimeTests
|
||||
// check spawned on server
|
||||
Assert.AreEqual(1, serverInstance.OnNetworkSpawnCalledCount);
|
||||
|
||||
// safety check despawned
|
||||
// safety check server despawned
|
||||
Assert.AreEqual(0, serverInstance.OnNetworkDespawnCalledCount);
|
||||
|
||||
// check spawned on client
|
||||
foreach (var clientInstance in clientInstances)
|
||||
// Conditional check for clients spawning or despawning
|
||||
var checkSpawnCondition = false;
|
||||
var expectedSpawnCount = 1;
|
||||
var expectedDespawnCount = 0;
|
||||
bool HasConditionBeenMet()
|
||||
{
|
||||
Assert.AreEqual(1, clientInstance.OnNetworkSpawnCalledCount);
|
||||
|
||||
// safety check despawned
|
||||
Assert.AreEqual(0, clientInstance.OnNetworkDespawnCalledCount);
|
||||
var clientsCompleted = 0;
|
||||
// check spawned on client
|
||||
foreach (var clientInstance in m_ClientTrackOnSpawnInstances)
|
||||
{
|
||||
if (checkSpawnCondition)
|
||||
{
|
||||
if (clientInstance.OnNetworkSpawnCalledCount == expectedSpawnCount)
|
||||
{
|
||||
clientsCompleted++;
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
if (clientInstance.OnNetworkDespawnCalledCount == expectedDespawnCount)
|
||||
{
|
||||
clientsCompleted++;
|
||||
}
|
||||
}
|
||||
}
|
||||
return clientsCompleted >= NumberOfClients;
|
||||
}
|
||||
|
||||
// despawn on server. However, since we'll be using this object later in the test, don't delete it (false)
|
||||
// safety check that all clients have not been despawned yet
|
||||
Assert.True(HasConditionBeenMet(), "Failed condition that all clients not despawned yet!");
|
||||
|
||||
// now verify that all clients have been spawned
|
||||
checkSpawnCondition = true;
|
||||
yield return WaitForConditionOrTimeOut(HasConditionBeenMet);
|
||||
Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out while waiting for client side spawns!");
|
||||
|
||||
// despawn on server. However, since we'll be using this object later in the test, don't delete it
|
||||
serverInstance.GetComponent<NetworkObject>().Despawn(false);
|
||||
|
||||
// check despawned on server
|
||||
Assert.AreEqual(1, serverInstance.OnNetworkDespawnCalledCount);
|
||||
// we now expect the clients to each have despawned once
|
||||
expectedDespawnCount = 1;
|
||||
|
||||
// wait long enough for player object to be despawned
|
||||
int nextFrameNumber = Time.frameCount + 2;
|
||||
yield return new WaitUntil(() => Time.frameCount >= nextFrameNumber);
|
||||
yield return s_DefaultWaitForTick;
|
||||
// verify that all client-side instances are despawned
|
||||
checkSpawnCondition = false;
|
||||
yield return WaitForConditionOrTimeOut(HasConditionBeenMet);
|
||||
|
||||
// check despawned on clients
|
||||
foreach (var clientInstance in clientInstances)
|
||||
{
|
||||
Assert.AreEqual(1, clientInstance.OnNetworkDespawnCalledCount);
|
||||
}
|
||||
|
||||
//----------- step 2 check spawn again and destroy
|
||||
Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out while waiting for client side despawns!");
|
||||
|
||||
//----------- step 2 check spawn and destroy again
|
||||
serverInstance.GetComponent<NetworkObject>().Spawn();
|
||||
|
||||
// wait long enough for player object to be spawned
|
||||
nextFrameNumber = Time.frameCount + 2;
|
||||
yield return new WaitUntil(() => Time.frameCount >= nextFrameNumber);
|
||||
|
||||
// wait a tick
|
||||
yield return s_DefaultWaitForTick;
|
||||
// check spawned again on server this is 2 because we are reusing the object which was already spawned once.
|
||||
Assert.AreEqual(2, serverInstance.OnNetworkSpawnCalledCount);
|
||||
|
||||
// check spawned on client
|
||||
foreach (var clientInstance in clientInstances)
|
||||
{
|
||||
Assert.AreEqual(1, clientInstance.OnNetworkSpawnCalledCount);
|
||||
}
|
||||
checkSpawnCondition = true;
|
||||
yield return WaitForConditionOrTimeOut(HasConditionBeenMet);
|
||||
|
||||
Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out while waiting for client side spawns! (2nd pass)");
|
||||
|
||||
// destroy the server object
|
||||
Object.Destroy(serverInstance.gameObject);
|
||||
|
||||
// wait one frame for destroy to kick in
|
||||
yield return null;
|
||||
yield return s_DefaultWaitForTick;
|
||||
|
||||
// check whether despawned was called again on server instance
|
||||
Assert.AreEqual(2, serverInstance.OnNetworkDespawnCalledCount);
|
||||
|
||||
// wait long enough for player object to be despawned on client
|
||||
nextFrameNumber = Time.frameCount + 2;
|
||||
yield return new WaitUntil(() => Time.frameCount >= nextFrameNumber);
|
||||
checkSpawnCondition = false;
|
||||
yield return WaitForConditionOrTimeOut(HasConditionBeenMet);
|
||||
|
||||
// check despawned on clients
|
||||
foreach (var clientInstance in clientInstances)
|
||||
{
|
||||
Assert.AreEqual(1, clientInstance.OnNetworkDespawnCalledCount);
|
||||
}
|
||||
Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out while waiting for client side despawns! (2nd pass)");
|
||||
}
|
||||
|
||||
private class TrackOnSpawnFunctions : NetworkBehaviour
|
||||
|
||||
Reference in New Issue
Block a user